Refactor wrapped scan plans so they more user friendly - #2050
Open
oliwenmandiamond wants to merge 31 commits into
Open
Refactor wrapped scan plans so they more user friendly#2050oliwenmandiamond wants to merge 31 commits into
oliwenmandiamond wants to merge 31 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
=======================================
Coverage 99.33% 99.34%
=======================================
Files 367 371 +4
Lines 14379 14412 +33
=======================================
+ Hits 14284 14317 +33
Misses 95 95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oliwenmandiamond
marked this pull request as ready for review
May 11, 2026 07:24
EmsArnold
reviewed
Jun 9, 2026
EmsArnold
left a comment
Contributor
There was a problem hiding this comment.
A few comments, but hopefully nothing too onerous. I would like to try it on test rig or similar if it hasn't been tested there yet.
…/DiamondLightSource/dodal into refactor_scans_so_they_are_flatter
…*args requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aims to make the scan syntax much more user friendly. Some examples are show below:
Old syntax
New syntax
When BlueAPI supports *args, we can simplifier this even further by removing the final set of brackets:
or BlueAPI client equivalent
I've also tried to improve the tests, they now check that the scan shape is correct and checks every custom error message for scan syntax being wrong for step scans.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}